Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve distributors validation and apply in-place filtering. #3134

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

cyriltovena
Copy link
Contributor

❯ benchcmp  before.txt after.txt
benchmark             old ns/op     new ns/op     delta
Benchmark_Push-16     18708519      1348876       -92.79%

benchmark             old allocs     new allocs     delta
Benchmark_Push-16     44             42             -4.55%

benchmark             old bytes     new bytes     delta
Benchmark_Push-16     4008391       2079          -99.95%

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

```bash
❯ benchcmp  before.txt after.txt
benchmark             old ns/op     new ns/op     delta
Benchmark_Push-16     18708519      1348876       -92.79%

benchmark             old allocs     new allocs     delta
Benchmark_Push-16     44             42             -4.55%

benchmark             old bytes     new bytes     delta
Benchmark_Push-16     4008391       2079          -99.95%
```

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@owen-d owen-d merged commit 82d96de into grafana:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants