label_format no longer shardable and introduces the Shardable() metho… #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jan 7, 2021
| @@ -456,6 +478,8 @@ func (r logRange) String() string { | |||
| return sb.String() | |||
| } | |||
|
|
|||
| func (r *logRange) Shardable() bool { return r.left.Shardable() } | |||
There was a problem hiding this comment.
Not sure this was a Expr.
There was a problem hiding this comment.
You're right, but it's called via rangeAggExpr.Shardable() -> logRange.Shardable() -> LogSelectorExpr.Shardable() so it seemed more obvious to use the same method :).
cyriltovena
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Shardable() boolmethod to theExprinterface. Now that we have pipeline stages which affect sharding (label_format), it's easier/more straightforward to implement at theExpritself rather than using theOperations()workaround that we had prior.Additionally,
label_formatis no longer shardable (bugfix as it mutates labels on shards and thus breaks guarantees).This also lays the groundwork for integrating the
dedupaddition in #3110