Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More semantically correct flush shutdown #3146

Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 8, 2021

The endpoint is now a bit more explicit that it flushes then shuts down.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #3146 (97debb7) into master (b72198c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3146   +/-   ##
=======================================
  Coverage   63.18%   63.19%           
=======================================
  Files         188      188           
  Lines       16305    16305           
=======================================
+ Hits        10303    10304    +1     
+ Misses       5063     5060    -3     
- Partials      939      941    +2     
Impacted Files Coverage Δ
pkg/loki/modules.go 3.25% <0.00%> (ø)
pkg/promtail/targets/file/tailer.go 72.97% <0.00%> (-5.41%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/canary/comparator/comparator.go 76.36% <0.00%> (-1.82%) ⬇️
pkg/logql/evaluator.go 90.23% <0.00%> (+0.35%) ⬆️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

@owen-d owen-d merged commit 6dc8bee into grafana:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants