Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make httpAuthMiddleware field public #3159

Merged

Conversation

MichelHollands
Copy link
Contributor

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@cyriltovena
Copy link
Contributor

Not sure the draft PR was intentional ?

@codecov-io
Copy link

Codecov Report

Merging #3159 (43de107) into master (1f6fd5e) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   63.34%   63.26%   -0.08%     
==========================================
  Files         188      188              
  Lines       16304    16304              
==========================================
- Hits        10327    10314      -13     
- Misses       5036     5050      +14     
+ Partials      941      940       -1     
Impacted Files Coverage Δ
pkg/loki/loki.go 0.00% <0.00%> (ø)
pkg/loki/modules.go 3.25% <0.00%> (ø)
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/ingester/transfer.go 60.14% <0.00%> (-1.45%) ⬇️

@MichelHollands
Copy link
Contributor Author

MichelHollands commented Jan 13, 2021

Not sure the draft PR was intentional ?

Yes it was. I'm still testing code based on this and I might have to make more fields public.
Update: seems like no more else needs changing for now. This PR is now ready for review.
Update2: I spoke too soon.

@MichelHollands MichelHollands marked this pull request as ready for review January 13, 2021 09:48
@MichelHollands MichelHollands marked this pull request as draft January 13, 2021 11:43
@owen-d
Copy link
Member

owen-d commented Jan 15, 2021

This looks fine to me. @MichelHollands Is this ready for review?

@MichelHollands MichelHollands marked this pull request as ready for review January 15, 2021 17:32
@MichelHollands
Copy link
Contributor Author

This looks fine to me. @MichelHollands Is this ready for review?

Yes, this can go in now. Thanks

@sandeepsukhani sandeepsukhani merged commit 56bf5e7 into grafana:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants