Improve checkpoint series iterator. #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
- Coverage 63.33% 63.23% -0.10%
==========================================
Files 191 191
Lines 16455 16514 +59
==========================================
+ Hits 10421 10442 +21
- Misses 5089 5128 +39
+ Partials 945 944 -1
|
owen-d
approved these changes
Jan 20, 2021
| // it's possible the stream has been flushed to storage | ||
| // in between starting the checkpointing process and | ||
| // checkpointing this stream. | ||
| return s.Next() |
There was a problem hiding this comment.
I can't think of a deadlock scenario while holding the chunk mutex here and calling s.Next(), but I am worried about it.
Comment on lines
+241
to
+248
| defer stream.chunkMtx.RUnlock() | ||
|
|
||
| if len(stream.chunks) < 1 { | ||
| // it's possible the stream has been flushed to storage | ||
| // in between starting the checkpointing process and | ||
| // checkpointing this stream. | ||
| return s.Next() | ||
| } |
There was a problem hiding this comment.
Suggested change
| defer stream.chunkMtx.RUnlock() | |
| if len(stream.chunks) < 1 { | |
| // it's possible the stream has been flushed to storage | |
| // in between starting the checkpointing process and | |
| // checkpointing this stream. | |
| return s.Next() | |
| } | |
| if len(stream.chunks) < 1 { | |
| // it's possible the stream has been flushed to storage | |
| // in between starting the checkpointing process and | |
| // checkpointing this stream. | |
| stream.chunkMtx.RUnlock() | |
| return s.Next() | |
| } | |
| defer stream.chunkMtx.RUnlock() |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactoring allowing to use less memory when iterating over series for checkpointing purpose.