Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix: cmd/docker-driver): Insert a space in the error message #3225

Merged
merged 1 commit into from
Jan 26, 2021
Merged

(fix: cmd/docker-driver): Insert a space in the error message #3225

merged 1 commit into from
Jan 26, 2021

Conversation

takaokanbe
Copy link
Contributor

Hello :)

In the error message, there is a space after the colon, but there is a part which is no space after the colon, so I inserted a space.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #3225 (d0bde18) into master (0208071) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3225      +/-   ##
==========================================
- Coverage   63.20%   63.18%   -0.02%     
==========================================
  Files         197      197              
  Lines       16685    16685              
==========================================
- Hits        10546    10543       -3     
- Misses       5184     5186       +2     
- Partials      955      956       +1     
Impacted Files Coverage Δ
cmd/docker-driver/config.go 9.34% <0.00%> (ø)
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/ingester/checkpoint.go 71.86% <0.00%> (-0.77%) ⬇️
pkg/logql/evaluator.go 89.87% <0.00%> (-0.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.89% <0.00%> (+2.06%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 931fdcb into grafana:master Jan 26, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* Removed the deprecated flag -config-yaml

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed doc

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants