Allocate entries array with correct size while decoding WAL entries. #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small optimization I found while deployment the new version. We might want to have a pool of entries here. ``` ❯ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_DecodeWAL-16 2350024 1591633 -32.27% benchmark old allocs new allocs delta Benchmark_DecodeWAL-16 20043 20005 -0.19% benchmark old bytes new bytes delta Benchmark_DecodeWAL-16 4946246 1763270 -64.35% ``` Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization I found while deployment the new version.
We might want to have a pool of entries here.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com