dist: Build promtail for windows/386 to support 32 bit windows hosts #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
reviewed
Jan 26, 2021
There was a problem hiding this comment.
This LGTM, but would like some signoffs from @slim-bean @cyriltovena who know a bit more about windows.
|
Tested it against our production Loki with some test files, everything seems to be working! |
cyriltovena
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It builds promtail for 32-bit Windows, to support deploying promtail on 32 bit
Windows hosts.
In our environment, we have a number of "Appliances" for industrial hardware
that ships with it's own PC and installation of Windows included, that isn't
necessarily "modern", nor something we can change/upgrade. We want to collect the logs for these systems, but
sometimes the hosts are 32 bit.