Ensure we have parentheses for bin ops. #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure we correctly keep the order of execution when we stringify a bin operation. This has recently introduced a bug because we now use stringify to deep clone a LogQL expression. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
commented
Jan 28, 2021
| } | ||
| return fmt.Sprintf("%s %s %s", e.SampleExpr.String(), e.op, e.RHS.String()) | ||
| return fmt.Sprintf("(%s %s %s)", e.SampleExpr.String(), e.op, e.RHS.String()) |
There was a problem hiding this comment.
This is the actual fix.
cyriltovena
added a commit
that referenced
this pull request
Jan 28, 2021
This ensure we correctly keep the order of execution when we stringify a bin operation. This has recently introduced a bug because we now use stringify to deep clone a LogQL expression. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure we correctly keep the order of execution when we stringify a bin operation.
This has recently introduced a bug because we now use stringify to deep clone a LogQL expression.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com