ksonnet: Remove invalid hostname from default promtail configuration #3254
Conversation
|
|
| @@ -10,7 +10,7 @@ | |||
| username:: '', | |||
| password:: '', | |||
| scheme:: 'https', | |||
| hostname:: 'logs-us-west1.grafana.net', | |||
| hostname:: 'set valid hostname here', | |||
There was a problem hiding this comment.
This is what you are looking for. It could be a breaking change though for people updating their lib and promtails suddenly stopping to work.
| hostname:: 'set valid hostname here', | |
| hostname:: error 'must define a valid hostname', |
There was a problem hiding this comment.
Thanks @sandeepsukhani - that looks perfect!
There was a problem hiding this comment.
It could be a breaking change though for people updating their lib and promtails suddenly stopping to work.
@sandeepsukhani If people are using this default setting, all they're getting is 404s, so it's not working for them anyway 😉
|
You'll need to sign the CLA, but this looks great. Thanks |
|
@owen-d is the CLA required for Grafana Labs employees? |
Signed-off-by: Dave Henderson <dave.henderson@grafana.com>
hairyhenderson
force-pushed
the
remove-incorrect-host-from-default-config
branch
from
89e54c8
to
a0f2e4d
Compare
|
I've signed the CLA anyway - the bot seems to have been a bit confused so I had to kick it 🤷♂️ |
What this PR does / why we need it:
We're seeing traffic attempting to hit this host (and failing), and I'm guessing it's coming from misconfigured promtail instances that are using this config. Simply changing this won't help instances that already have this configuration, but in case they're updated at a future date they'll at least fail with a semi-recognizable error.
There may be a better way to declare that the value is required, but I am a jsonnet novice 😅.
Special notes for your reviewer:
Checklist
Signed-off-by: Dave Henderson dave.henderson@grafana.com