Make incoming labels from gcp into Loki internal labels. #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these labels are significant, we can always use relabeling.
Codecov Report
@@ Coverage Diff @@
## master #3285 +/- ##
==========================================
- Coverage 62.64% 62.64% -0.01%
==========================================
Files 201 201
Lines 17110 17129 +19
==========================================
+ Hits 10719 10730 +11
- Misses 5431 5439 +8
Partials 960 960
|
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Feb 5, 2021
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Feb 5, 2021
rfratto
added a commit
to grafana/agent
that referenced
this pull request
Feb 5, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Feb 15, 2021
* Make incoming labels from gcp into Loki internal labels. If these labels are significant, we can always use relabeling. * Add support for rebeling in gcptarget * Test for SnakeCase
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* fix timeout handling in GetObject for azure and gcs Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * wrapped readcloser which helps with cancelling the context when reader is closed Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * update changelog Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * changes suggested from PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * changes suggested from PR review Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * update comments Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
mattdurham
pushed a commit
to grafana/agent
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these labels are significant, we can always use relabeling.
What this PR does / why we need it:
Convert incoming GCP labels into Loki internal labels by default
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
These internal labels can be made to normal labels by relabeling on demand.
Checklist