Promtail: fix typo in config variable name - BookmarkPath #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
+ Coverage 62.57% 62.59% +0.02%
==========================================
Files 201 201
Lines 17142 17142
==========================================
+ Hits 10726 10730 +4
Misses 5452 5452
+ Partials 964 960 -4
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Feb 15, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…rafana#3298) * Redis cache: added parameter to disable SSL certificate verification Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@sysdig.com> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <marco@pracucci.com> * addressed comments Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@sysdig.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixing typo in config variable name: BoorkmarkPath -> BookmarkPath (an "r" just before first "k")
Special notes for your reviewer:
I believe this is just a typo and not intentional misspelling. Google search for dictionary entry for term "Boorkmark" doesn't find anything interesting.
@cyriltovena can you have a look at this? Found it when playing with the new addition to the promtail. Great work!
Checklist