increase db retain period in ingesters to cover index cache validity period as well #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…period as well refactor ingester store query config to simplify the code
sandeepsukhani
force-pushed
the
boltdb-shipper-ingester-db-retain-period-fix
branch
2 times, most recently
from
16d1023
to
c20dc36
Compare
|
Hey Folks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We encountered that internal canaries were reporting missing logs intermittently.
While the logs were there in the storage they were sometimes not being returned in the query results.
Investigating the queries which had the problem I noticed that we were not retaining dbs long enough to cover the expiry of the cached index by queriers. We need to cover the expiry as well since queriers could keep serving chunks for stale index which could be missing recently flushed chunk ids.
I have also refactored the code to simplify the calculations of various durations for boltdb-shipper a bit.