Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project-id from the variables. Remove hardcoding #3304

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Use project-id from the variables. Remove hardcoding #3304

merged 1 commit into from
Feb 10, 2021

Conversation

kavirajk
Copy link
Collaborator

@kavirajk kavirajk commented Feb 8, 2021

What this PR does / why we need it:
Minor fix on gcplog tf script. Take project input from variables.

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@kavirajk kavirajk requested a review from a team February 8, 2021 17:14
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 7cd70aa into grafana:master Feb 10, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants