Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes step encoding in logcli. #3325

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

cyriltovena
Copy link
Contributor

The step.Seconds float was casted into a int making it impossible to go sub second.

Fixes #3318

Fixes grafana#3318

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3325 (03e5678) into master (82cead2) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
+ Coverage   62.59%   62.60%   +0.01%     
==========================================
  Files         201      201              
  Lines       17144    17144              
==========================================
+ Hits        10731    10733       +2     
+ Misses       5450     5449       -1     
+ Partials      963      962       -1     
Impacted Files Coverage Δ
pkg/logcli/client/client.go 5.50% <0.00%> (ø)
pkg/querier/queryrange/limits.go 91.66% <0.00%> (-4.17%) ⬇️
pkg/logql/evaluator.go 90.19% <0.00%> (+0.35%) ⬆️
pkg/promtail/targets/file/tailer.go 75.00% <0.00%> (+1.78%) ⬆️

@cyriltovena cyriltovena merged commit 15b6235 into grafana:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logcli does not suport <1s resolution of step value
3 participants