fix config for statefulset rulers when using boltdb-shipper #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Feb 12, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Feb 15, 2021
…3329) Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were setting
stateful_rulerstotrueinboltdb-shipper.libsonnetwhich actually gets imported afterruler.libsonnetwhich causes it to define deployment type instead of statefulset type even when usingboltdb-shipper.This PR sets the required config in
ruler.libsonnetincludingboltdb.shipper.cache-locationwhen usingboltdb-shipper.