Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Start() method to WAL interface to delay checkpointing until aft… #3339

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 15, 2021

…er replay

@codecov-io
Copy link

Codecov Report

Merging #3339 (7a614fc) into master (76e713f) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
- Coverage   62.72%   62.71%   -0.01%     
==========================================
  Files         205      205              
  Lines       17310    17312       +2     
==========================================
  Hits        10857    10857              
- Misses       5478     5480       +2     
  Partials      975      975              
Impacted Files Coverage Δ
pkg/ingester/wal.go 80.45% <50.00%> (-0.94%) ⬇️
pkg/ingester/ingester.go 49.39% <100.00%> (+0.15%) ⬆️
pkg/ingester/checkpoint.go 72.62% <0.00%> (-1.15%) ⬇️
pkg/logql/evaluator.go 90.19% <0.00%> (+0.35%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 862cfa4 into grafana:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants