Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some operation details to gcplog doc #3351

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Add some operation details to gcplog doc #3351

merged 4 commits into from
Feb 22, 2021

Conversation

kavirajk
Copy link
Collaborator

What this PR does / why we need it:
Add some operation steps to gcplog doc

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:

Checklist

  • Documentation added

@kavirajk kavirajk requested a review from a team February 17, 2021 16:39

Sometimes you may have to check how much logs you are writting to the pubsub topic (mostly for cost estimation).

These messages stays in Pubsub Subscription till its acknowledged. Following command just removes those log messages without having it to be consumed via promtail or any other pubsub consumer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these alternatively be configured via a TTL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. we do have message-retention-duration for the specific subscription. But it usually be 7 or 10 days in production. And we can change of course during creation of the subscription.

But this operation steps is to inform there is another way to clear those messages rather than waiting till message-retention-duration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked and you already have that retention config covered in the doc. LGTM

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits then LGTM

docs/sources/clients/promtail/gcplog-cloud.md Outdated Show resolved Hide resolved
docs/sources/clients/promtail/gcplog-cloud.md Outdated Show resolved Hide resolved
docs/sources/clients/promtail/gcplog-cloud.md Outdated Show resolved Hide resolved
kavirajk and others added 3 commits February 22, 2021 17:10
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d merged commit cb59069 into grafana:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants