Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Fix parser hint for extracted labels which collide with stream labels #3380

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

slim-bean
Copy link
Collaborator

This is one possible solution but without knowing this code real well I suspect it's not the best solution.

…st add a new label with the suffix removed. This will avoid any cases where a legit json or logfmt key ends with _extracted.
@slim-bean slim-bean changed the title WIP: Fix parser hint for extracted labels which collide with stream labels Loki: Fix parser hint for extracted labels which collide with stream labels Feb 24, 2021
@codecov-io
Copy link

Codecov Report

Merging #3380 (3847305) into master (287244d) will increase coverage by 0.41%.
The diff coverage is 66.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
+ Coverage   62.44%   62.86%   +0.41%     
==========================================
  Files         200      205       +5     
  Lines       17101    17401     +300     
==========================================
+ Hits        10679    10939     +260     
- Misses       5457     5479      +22     
- Partials      965      983      +18     
Impacted Files Coverage Δ
cmd/docker-driver/main.go 0.00% <0.00%> (ø)
cmd/migrate/main.go 5.40% <0.00%> (ø)
cmd/querytee/main.go 0.00% <0.00%> (ø)
pkg/chunkenc/memchunk.go 68.10% <0.00%> (ø)
pkg/distributor/http.go 0.00% <0.00%> (ø)
pkg/ingester/stream.go 70.86% <0.00%> (ø)
pkg/ingester/tailer.go 43.80% <0.00%> (ø)
pkg/logcli/client/client.go 5.50% <0.00%> (-0.06%) ⬇️
pkg/logcli/query/query.go 34.80% <0.00%> (ø)
pkg/logcli/query/tail.go 0.00% <0.00%> (ø)
... and 73 more

@slim-bean slim-bean merged commit 74a9789 into master Feb 25, 2021
@slim-bean slim-bean deleted the parser-hint-extracted branch February 25, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants