Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support max_message_length configuration for syslog parser #3400

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

adityacs
Copy link
Collaborator

What this PR does / why we need it:
support max_message_length configuration for syslog parser

Which issue(s) this PR fixes:
Fixes #3398

Checklist

  • Documentation added
  • Tests updated

Comment on lines 321 to 323
if maxMessageLength := t.config.MaxMessageLength; maxMessageLength != 0 {
return maxMessageLength
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if maxMessageLength := t.config.MaxMessageLength; maxMessageLength != 0 {
return maxMessageLength
}
if t.config.MaxMessageLength != 0 {
return t.config.MaxMessageLength
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit.

@cyriltovena cyriltovena merged commit bf4fa66 into grafana:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail octet-framed syslog failing for large messages.
2 participants