Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributor: append several tests for HTTP parser. #3416

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Distributor: append several tests for HTTP parser. #3416

merged 1 commit into from
Mar 3, 2021

Conversation

ukolovda
Copy link
Contributor

@ukolovda ukolovda commented Mar 2, 2021

What this PR does / why we need it:
Append several test cases for distributor HTTP parser.

Which issue(s) this PR fixes:
Addressed to #3407,#3408, #3291, #3205

Special notes for your reviewer:
Sorry, I have not experience with Protobuf and Snappy. This cases

Checklist

  • Documentation added
  • Tests updated

@ukolovda ukolovda changed the title Distributor: append several tests for http parser. Distributor: append several tests for HTTP parser. Mar 2, 2021
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Thanks ! LGTM

@cyriltovena cyriltovena merged commit 6ea7122 into grafana:master Mar 3, 2021
@ukolovda ukolovda deleted the distributor_http_test branch March 9, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants