Upgrade Cortex #3466
Merged
Upgrade Cortex #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
upgrade-cortex
branch
from
3f3f867
to
aea0218
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I've just merged the Cortex PR cortexproject/cortex#3915 where we removed deprecated aliases in
pkg/ingester/client(already moved topkg/cortexpb). In this PR I'm upgrading Cortex into Loki trying to offload the (little) burden from you.There have been few other changes in the meanwhile:
1.34.0(finally etcd client has been fixed)ring.IngesterStatetoring.InstanceState(ring is used by many components nowadays so we're removing the "ingester" naming from there)Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist