Set a max size for the logql parser to 5k. #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API anyway receives the query via querystring which is normally max out by 2k based on RFC2616. This will improve fuzzing too. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
kavirajk
reviewed
Mar 10, 2021
| @@ -22,6 +23,8 @@ var parserPool = sync.Pool{ | |||
| }, | |||
| } | |||
|
|
|||
| const maxInputSize = 5120 | |||
There was a problem hiding this comment.
why 5K?
Suggested change
| const maxInputSize = 5120 | |
| const maxInputSize = 5 * (1 << 10) // 5K |
There was a problem hiding this comment.
5k is mostly arbitrary, the max a query param should be in a URL is 2k so this was a number bigger than that but still with some extra room
There was a problem hiding this comment.
To my knowledge nothing enforces that 2KB limit; also I believe one can POST queries which removes that consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API anyway receives the query via querystring which is normally max out by 2k based on RFC2616.
This will improve fuzzing too.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com