Set the byte slice cap correctly when unsafely converting string. #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grafana#3485 Should also unblock grafana#3481 When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string. It seems that this is only a problem when using go 1.16 or when using delve. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
| var buf []byte | ||
| p := unsafe.Pointer(&buf) | ||
| *(*string)(p) = s | ||
| (*reflect.SliceHeader)(p).Cap = len(s) |
There was a problem hiding this comment.
OMG yes! This would always give me issues when using delve
dannykopping
approved these changes
Mar 15, 2021
perrinjerome
pushed a commit
to perrinjerome/loki
that referenced
this pull request
Jun 10, 2021
…afana#3487) Fixes grafana#3485 Should also unblock grafana#3481 When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string. It seems that this is only a problem when using go 1.16 or when using delve. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3485
Should also unblock #3481
When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string.
It seems that this is only a problem when using go 1.16 or when using delve.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com