make prefix for keys of objects created by boltdb-shipper configurable #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
BoltDB Shipper stores object with the
index/prefix which is hardcoded which limits the usage of a single bucket to a single Loki cluster when usingboltdb-shipperas index store.To allow users to share a bucket with multiple Loki clusters using
boltdb-shipper, we want to make the object key prefix configurable so that different Loki clusters store the index with different prefix hence isolate the index.Special notes for your reviewer:
This should not be a breaking change since we are defaulting the value of the config to
index/which was hardcoded previously.