Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sprig text/template functions to template stage. #3515

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

cyriltovena
Copy link
Contributor

Fixes #3129

Fixes grafana#3129

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3515 (6447764) into master (b06d970) will decrease coverage by 0.00%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
- Coverage   63.05%   63.05%   -0.01%     
==========================================
  Files         206      206              
  Lines       17681    17682       +1     
==========================================
  Hits        11149    11149              
  Misses       5531     5531              
- Partials     1001     1002       +1     
Impacted Files Coverage Δ
pkg/logentry/stages/template.go 81.03% <76.47%> (+0.33%) ⬆️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/querier/queryrange/limits.go 86.66% <0.00%> (-1.91%) ⬇️
pkg/logql/evaluator.go 90.19% <0.00%> (+0.35%) ⬆️
pkg/storage/stores/shipper/uploads/table.go 66.82% <0.00%> (+0.46%) ⬆️

Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sandeepsukhani sandeepsukhani merged commit 71aa8a6 into grafana:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mutations such as mutiplication/division to allow exposing metrics in the proper units
4 participants