Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBAC changes #3549

Merged
merged 4 commits into from
Mar 30, 2021
Merged

LBAC changes #3549

merged 4 commits into from
Mar 30, 2021

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Mar 26, 2021

Add the changes for LBAC support.

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands changed the title lbac changes WIP: lbac changes Mar 26, 2021
@MichelHollands MichelHollands changed the title WIP: lbac changes LBAC changes Mar 30, 2021
@MichelHollands MichelHollands marked this pull request as ready for review March 30, 2021 08:16
Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/loki/modules.go Outdated Show resolved Hide resolved
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit ffbabc5 into grafana:master Mar 30, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
- Introduced API for tenant deletion.
- Ingester: don't ship blocks and close TSDB faster if tenant deletion mark exists.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants