Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3552

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Update README.md #3552

merged 1 commit into from
Mar 30, 2021

Conversation

lkokila
Copy link
Contributor

@lkokila lkokila commented Mar 28, 2021

With Go 1.11 it's not possible to build the Fluent Bit plugin with the following error.

build github.com/sercand/kuberesolver: cannot find module for path github.com/sercand/kuberesolver

Needed to use Go 1.16.2 to resolve the issue.

This should be related to sercand/kuberesolver#11

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

With Go 1.11 it's not possible to build the Fluent Bit plugin with the following error.

```
build github.com/sercand/kuberesolver: cannot find module for path github.com/sercand/kuberesolver
```
Needed to use Go 1.16.2 to resolve the issue.
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #3552 (1fb61a8) into master (37a7189) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3552   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files         206      206           
  Lines       17698    17698           
=======================================
+ Hits        11161    11162    +1     
+ Misses       5536     5535    -1     
  Partials     1001     1001           
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.82% <0.00%> (-2.07%) ⬇️
pkg/querier/queryrange/limits.go 88.57% <0.00%> (+5.71%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e0f0ee0 into grafana:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants