Promtail: Remove non-ready filemanager targets #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsteneteg
force-pushed
the
rsteneteg/remove-non-ready-targets
branch
from
002317a
to
84fa896
Compare
|
|
…e removed and recreated during next sync Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
rsteneteg
force-pushed
the
rsteneteg/remove-non-ready-targets
branch
from
9623cc9
to
8ad265d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove targets that dont have any tails, in order for the target to be removed and recreated during next sync
Signed-off-by: Roger Steneteg rsteneteg@ea.com
What this PR does / why we need it:
This PR fixes a bug that causes Promtail to stop tailing statefulset pods after they are deleted/rescheduled
Which issue(s) this PR fixes:
Fixes #3586
Special notes for your reviewer:
The bug seems to be some race condition where the pod is deleted and recreated before the filetarget has been removed, this fix removes any filetarget that no longer has any tails, allowing them to be recreated which solves the problem, but it does not address the actual race condition.
Checklist