Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard/fix operational vars #3601

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Dashboard/fix operational vars #3601

merged 2 commits into from
Apr 13, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Apr 12, 2021

This improves both the default json dashboard definition by excluding the loki-canary from namespace selections and uses the refined variable queries in the jsonnet overlay.

kavirajk
kavirajk approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

slim-bean
slim-bean approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 7bac502 into grafana:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavirajk kavirajk kavirajk approved these changes

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@owen-d @kavirajk @slim-bean