Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] add '/config' page #3619

Merged
merged 4 commits into from
Jul 22, 2021
Merged

[ui] add '/config' page #3619

merged 4 commits into from
Jul 22, 2021

Conversation

liguozhong
Copy link
Contributor

[ui] add '/config' page
image

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cyriltovena
Copy link
Contributor

Love it Thanks @liguozhong. We'll need to merge main though but that looks super good.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 2, 2021
@sandeepsukhani
Copy link
Contributor

@liguozhong can you please rebase this to get it merged?

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 9, 2021
@liguozhong
Copy link
Contributor Author

@liguozhong can you please rebase this to get it merged?

👌

@liguozhong
Merge branch 'main' into ui/config
851d52f 
# Conflicts:
#	clients/pkg/promtail/config/config.go
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 18, 2021
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 18, 2021
@liguozhong
Copy link
Contributor Author

@liguozhong can you please rebase this to get it merged?

done.

@liguozhong
Copy link
Contributor Author

@liguozhong can you please rebase this to get it merged?

done.

@sandeepsukhani Review required

@stale
Copy link

stale bot commented Jul 20, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jul 20, 2021
dannykopping
dannykopping approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jul 22, 2021
kavirajk
kavirajk approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dannykopping dannykopping merged commit 29cc5ad into grafana:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liguozhong @CLAassistant @cyriltovena @sandeepsukhani @dannykopping @kavirajk