Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wget link. #3633

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix wget link. #3633

merged 1 commit into from
Apr 21, 2021

Conversation

osg-grafana
Copy link
Contributor

Fix #33190 in the grafana repo.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@osg-grafana osg-grafana linked an issue Apr 21, 2021 that may be closed by this pull request
Docs feedback: /getting-started/get-logs-into-loki.md #3634
Closed
@osg-grafana osg-grafana requested review from 09jvilla, jtlisi, a team, oddlittlebird and achatterjee-grafana and removed request for a team April 21, 2021 11:57
@osg-grafana osg-grafana self-assigned this Apr 21, 2021
09jvilla
09jvilla approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@09jvilla 09jvilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the new link works and the old link does not - LGTM.

achatterjee-grafana
achatterjee-grafana approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit f0715a2 into main Apr 21, 2021
@owen-d owen-d deleted the bug/fix-wget-link-33190 branch April 21, 2021 13:42
@owen-d owen-d mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

@09jvilla 09jvilla 09jvilla approved these changes

@achatterjee-grafana achatterjee-grafana achatterjee-grafana approved these changes

@jtlisi jtlisi Awaiting requested review from jtlisi

@oddlittlebird oddlittlebird Awaiting requested review from oddlittlebird

Assignees

@osg-grafana osg-grafana

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs feedback: /getting-started/get-logs-into-loki.md
5 participants
@osg-grafana @CLAassistant @owen-d @09jvilla @achatterjee-grafana