Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtail: added timezone to logger in dry-run mode #3679" #3683

Merged
merged 1 commit into from
May 5, 2021
Merged

promtail: added timezone to logger in dry-run mode #3679" #3683

merged 1 commit into from
May 5, 2021

Conversation

kbudde
Copy link
Contributor

@kbudde kbudde commented May 4, 2021

What this PR does / why we need it:
Promtail --dry-run is missing the timezone in output.
If you want to test test stage "timestamp" you are unable to see if it works or not without importing the data into loki.

With this PR you just have to check dry-run output.

Which issue(s) this PR fixes:
Fixes #3679

Signed-off-by: Kris Budde Kris@budd.ee

Signed-off-by: Kris Budde <Kris@budd.ee>
@CLAassistant
Copy link

CLAassistant commented May 4, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 3331315 into grafana:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promtail: timestamp in --dry-run mode is missing timezone information
3 participants