Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Documentation: Fix document links for /loki/api/v1/push example #3690

Merged
merged 1 commit into from
May 18, 2021
Merged

API Documentation: Fix document links for /loki/api/v1/push example #3690

merged 1 commit into from
May 18, 2021

Conversation

atxviking
Copy link
Contributor

What this PR does / why we need it:

  • Updates link where primary branch updated to main
  • Fixes broken link where package looks to have moved

Which issue(s) this PR fixes:

  • N/A

Special notes for your reviewer:

  • This is purely a documentation update and hopefully I've followed proper update protocol

Checklist

  • [ X ] Documentation added
  • [ N/A ] Tests updated

@CLAassistant
Copy link

CLAassistant commented May 5, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

xDWart
xDWart approved these changes May 9, 2021
View reviewed changes
Copy link

@xDWart xDWart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to do the same thing :)

cyriltovena
cyriltovena approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit f6dcd3f into grafana:main May 18, 2021
@atxviking atxviking deleted the update_links branch May 19, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@xDWart xDWart xDWart approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atxviking @CLAassistant @cyriltovena @xDWart