Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug information for extracted data #3711

Merged
merged 6 commits into from
May 18, 2021
Merged

Conversation

3Xpl0it3r
Copy link
Contributor

What this PR does / why we need it:
User need to know what happened in parsing stage.

As parsing stages parse log line and extract some data into a map that called extracted data, but user this is not visible for user even in debug model. so user will this this stage doesn't work. As Issue #3702

Which issue(s) this PR fixes:
Fixes #3702

@3Xpl0it3r
Copy link
Contributor Author

@cyriltovena yeah, I am fixing it, thank you for reminding me.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 89bdc9c into grafana:main May 18, 2021
@3Xpl0it3r 3Xpl0it3r deleted the issue3702 branch June 18, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promtail: replace stage source field not used, causes stage to be ignored
2 participants