New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boltdb shipper deletion fixes #3746

Merged

sandeepsukhani merged 2 commits into grafana:main from sandeepsukhani:boltdb-shipper-deletion-fixes

May 19, 2021

Contributor

sandeepsukhani commented May 19, 2021

What this PR does / why we need it:
It comprises of 2 fixes related to deletion support for boltdb-shipper:

I had used break instead of return in a select case which caused the loop to continue and not stop the compactor.
We need to skip compaction or apply retention on delete requests table.

sandeepsukhani added 2 commits

May 19, 2021 16:44


          use return instead of break in select case

ca35f30


          skip compaction on delete requests table

6150cf1

pull-request-size bot added the size/M label

cyriltovena approved these changes

View reviewed changes

Contributor

cyriltovena left a comment

LGTM

sandeepsukhani merged commit 3b26c63 into grafana:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment