docs: Change redis configuration value for enabling TLS to correct syntax #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable_tls: true doesn't work and this syntax is taken from cortex documentation, works, and is tested with AWS ElastiCache Redis cluster
|
|
KMiller-Grafana
approved these changes
Jun 8, 2021
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…stributor.Distributor` service name. (grafana#3798) * Moved common protobuf code to new cortexpb package. Created distributorpb package, and moved cortex.IngesterOnlyPush to distributor.Distributor. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Comment every deprecated element individually to get warnings for all of them. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Ignore lint warnings from deprecated.go. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix lint warnings. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Verify that type alias for cortexpb.Sample uses correct functions for json marshalling. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR corrects the documentation (enable_tls: true doesn't work and this new syntax is taken from cortex documentation, works, and is tested with AWS ElastiCache Redis cluster)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist