Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 docs options for promtail client #3829

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

arempter
Copy link
Contributor

@arempter arempter commented Jun 9, 2021

What this PR does / why we need it:

This PR adds documentation section how to configure Promtail client with oauth2 settings.
Main branch already contains Prometheus HTTPClientConfig which can be configured to use oauth2. It was just not documented

Which issue(s) this PR fixes:
It is related to open issue #2998

Checklist

  • Documentation added

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2021

CLA assistant check
All committers have signed the CLA.

@KMiller-Grafana KMiller-Grafana requested a review from a team June 9, 2021 23:09
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation looks good to me. One of the Loki maintainers will need to review it for technical correctness.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for all your work in the original issue and here :)

@owen-d owen-d merged commit c756113 into grafana:main Jun 22, 2021
@copolycube
Copy link

copolycube commented Dec 21, 2022

Hello @arempter

do I understand correctly that this added doc explains that I can generate an application token from and Identity provider (for example gitlab.com, https://docs.gitlab.com/ee/integration/oauth_provider.html#group-owned-applications )

and this will allow promtail to connect to a loki instance residing behind an OAuth2 authentication layer (oauth2 configured with caddy webserver and using the same identity provider, i.e. gitlab.com) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants