Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit main to pull loki and promtail to install it via Tanka #3848

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

kavirajk
Copy link
Collaborator

What this PR does / why we need it:

Fixes installation in latest doc. using jb to pull latest loki and promtail fails because by default jb command, assumes master branch, but Loki repo renamed the master to main branch.

Which issue(s) this PR fixes:
Fixes #3808

Special notes for your reviewer:
NA

Checklist

  • Documentation added
  • Tests updated

Rationale is, by default `jb` command, assumes `master` branch, but Loki repo renamed
the `master` to `main` branch.
@kavirajk kavirajk requested a review from a team June 14, 2021 07:59
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyriltovena cyriltovena merged commit 450d915 into main Jun 14, 2021
@cyriltovena cyriltovena deleted the docs/fix-tanka-installation branch June 14, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not installed loki with tanka
3 participants