Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: index-gateway for boltdb-shipper index store #3865

Merged

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Add a new service called IndexGateway, which lets queriers and rulers query for the boltdb index when using the boltdb-shipper index store. Index Gateway helps run queriers and rulers without a persistent volume for storing the index locally to serve the queries.

The number of required gateway instances should be a lot less compared to querier instances that save cost on PV required with each querier instance.

Checklist

  • Tests updated

{
_config+:: {
use_index_gateway: false,
index_gateway_pvc_size: '10Gi',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default to something bigger? 100Gi maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a small cluster like dev clusters in our case, it would be too much. Most users won't need that much space if they do not set query readiness, which defaults to 0. If at all, we can go for 50Gi for now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tricky one, what do we default the querier pvcs too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if someone is going to use the index gateway it would likely be because they run a bigger cluster, so I think 50G or bigger as a default would be better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We default querier pvcs to 10Gi. I have set it to 50Gi for index gateway.
Please let me know if you want to increase it further.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but otherwise LGTM!

@sandeepsukhani sandeepsukhani merged commit 2c5ce2c into grafana:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants