Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explict syntax for using pattern parser #3871

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

kavirajk
Copy link
Collaborator

@kavirajk kavirajk commented Jun 21, 2021

What this PR does / why we need it:
Add explict syntax for using pattern parser

Motivation is from community discussion
https://community.grafana.com/t/how-to-use-loki-pattern-parser/49195

It also makes it consistent with other parsers explanations in the doc

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

docs/sources/logql/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given owen-d's change that adds a space character.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
@sandeepsukhani sandeepsukhani merged commit b77bb56 into main Jun 22, 2021
@sandeepsukhani sandeepsukhani deleted the pattern-doc-add-full-syntax branch June 22, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants