Make overrides configmap names and mount path as variables.
#3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
commented
Jun 23, 2021
| 'boltdb.shipper.cache-location': '/data/boltdb-cache', | ||
| } else {}, | ||
| // Use PVC for caching | ||
| 'boltdb.shipper.cache-location': '/data/boltdb-cache', |
There was a problem hiding this comment.
This the result of make fmt-jsonnet
There was a problem hiding this comment.
Thanks for taking care of this!
| @@ -3,16 +3,16 @@ | |||
|
|
|||
| _config+:: { | |||
| stateful_ingesters: if $._config.wal_enabled then true else super.stateful_ingesters, | |||
| loki+:with({ | |||
| ingester+:{ | |||
| loki+: with({ | |||
There was a problem hiding this comment.
This is also the result of make fmt-jsonnet
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajk
force-pushed
the
jsonnet-make-configmap-variables
branch
from
1bfb709
to
845ac86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of hardcoding the names and mount path of configmap
overrides, make it as variables.Note: This doesn't impact any of the existing workloads, as the default value for these variables are same the one hardcoded!
Which issue(s) this PR fixes:
Fixes: NA
Special notes for your reviewer:
Checklist