Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make identification of experimental items consistent and obvious #3911

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

KMiller-Grafana
Copy link
Contributor

I found more than one way that experimental features are indicated within the docs. This PR attempts to make them more obvious to the reader by highlighting prose in yellow. I've also attempted to make this indication consistent for all the features currently marked as experimental.

Found and removed 2 indications of experimental (boltDB-shipper) that are no longer experimental.

@@ -8,7 +8,8 @@ Retention in Loki is achieved either through the [Table Manager](#table-manager)

Retention through the [Table Manager](../table-manager/) is achieved by relying on the object store TTL feature, and will work for both [boltdb-shipper](../boltdb-shipper) store and chunk/index store. However retention through the [Compactor](../boltdb-shipper#compactor) is supported only with the [boltdb-shipper](../boltdb-shipper) store.

The [Compactor](#Compactor) retention will become the default and have long term support. While this retention is still **experimental**, it supports more granular retention policies on per tenant and per stream use cases.
<span style="background-color:#f3f973;">Retention through the [Compactor](#Compactor) is experimental.</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github markdown does not support setting the background colour for text. This would only work for docs hosted on Grafana.
People reading the docs on the Github repo would see it in plain text https://github.com/grafana/loki/blob/79ed6ffdea5d66935f6adeac4abadfcc9cce3624/docs/sources/operations/storage/retention.md

There are some suggestions there to use a diff block to highlight the text in this issue github/markup#1440

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I am only doing this for hosted docs. And, this is a temporary solution. I just wanted something quick and easily removable for the upcoming 2.3.0 release.

What do you think about using this as a temporary and partial fix until we decide if there is a more permanent way of solving what I think is a readability issue, @sandeepsukhani ?

@owen-d owen-d merged commit 7eceea0 into grafana:main Jul 6, 2021
@KMiller-Grafana KMiller-Grafana deleted the docs/colorize-experimental branch July 7, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants