optimize table retetion #3934
Merged
optimize table retetion #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
skip-retention
branch
from
1cba7d4
to
9bc47cb
Compare
sandeepsukhani
commented
Jul 2, 2021
| @@ -29,22 +30,27 @@ import ( | |||
|
|
|||
| type mockChunkClient struct { | |||
| mtx sync.Mutex | |||
| deletedChunks []string | |||
| deletedChunks map[string]struct{} | |||
There was a problem hiding this comment.
This fixes a flaky test when there can be duplicate chunk ids due to them overlapping 2 days and hence getting indexed in 2 tables. When chunk from each table gets deleted they get added here, hence creating a duplicate entry.
cc @cyriltovena
…period and there are no overlapping delete requests
sandeepsukhani
force-pushed
the
skip-retention
branch
from
9bc47cb
to
83a5f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip applying retention when data in table is still within retention …period and there are no overlapping delete requests
What this PR does / why we need it:
During each compaction, we download and iterate through all the tables and check each table for whether there are any chunks expired due to configured retention policy or a user issued delete request.
This causes the compaction to slow down and wastes the resources. This PR changes the code to check whether a table would have any expired data due to configured retention period or user issued delete request before applying retention to it. If there is no expired data then the whole table would be skipped.
Checklist