Lint script files. #3944
Merged
Lint script files. #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a Drone CI step that runs shellcheck on all Bash script files.
|
|
jeschkies
commented
Jul 5, 2021
| - name: shellcheck | ||
| image: koalaman/shellcheck-alpine:stable | ||
| commands: | ||
| - apk add make bash && make lint-scripts |
There was a problem hiding this comment.
I've follow the pattern make lint-jsonnet and make lint-markdown. However, it would be easier to just have a shellcheck script file and avoid installing make and bash here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch adds a Drone CI step that runs shellcheck on all Bash script
files.