Unordered head block #3957
Merged
Unordered head block #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd constant for current default chunk version
cyriltovena
reviewed
Jul 8, 2021
| @@ -350,7 +352,7 @@ func NewByteChunk(b []byte, blockSize, targetSize int) (*MemChunk, error) { | |||
| // Verify checksums. | |||
| expCRC := binary.BigEndian.Uint32(b[blk.offset+l:]) | |||
| if expCRC != crc32.Checksum(blk.b, castagnoliTable) { | |||
| level.Error(util_log.Logger).Log("msg", "Checksum does not match for a block in chunk, this block will be skipped", "err", ErrInvalidChecksum) | |||
| _ = level.Error(util_log.Logger).Log("msg", "Checksum does not match for a block in chunk, this block will be skipped", "err", ErrInvalidChecksum) | |||
There was a problem hiding this comment.
You shouldn't need this does the linter caused you trouble ? Might be just locally.
There was a problem hiding this comment.
Ah, might be a version mismatch - I usually run the linter outside of docker and it's a bit noisy :)
cyriltovena
reviewed
Jul 8, 2021
| // []byte here doesn't create allocation because Sum64 has go:noescape directive | ||
| // It specifies that the function does not allow any of the pointers passed as arguments | ||
| // to escape into the heap or into the values returned from the function. | ||
| h := xxhash.Sum64([]byte(line)) |
There was a problem hiding this comment.
Recently change this one of us will have to be careful.
cyriltovena
reviewed
Jul 8, 2021
| } | ||
| seriesRes := make([]logproto.Series, 0, len(series)) | ||
| for _, s := range series { | ||
| // todo(ctovena) not sure we need this sort. |
There was a problem hiding this comment.
we don't in the end took me long to come back :)
cyriltovena
approved these changes
Jul 8, 2021
|
ref #1544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a no-op which adds some new (currently unused) code for an unordered head block. This will lay the groundwork for removing the ordering constraint and breaks this code into it's own PR.