log name of the file failed to open during startup by ingester #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When an active index file is corrupted due to Loki/Ingester abruptly stopping, it causes Loki/Ingester to fail to start.
We automatically clean up a corrupted file in the
boltdb-cache, which we can download again from the object store, but we can't recover a file corrupted in the active index directory.I would not prefer to remove the corrupt file without someone intervening manually because a corrupt file means something is wrong, and that happening frequently could cause data loss. So this PR keeps the behaviour the same but lets the user know which file is corrupt to either try to fix it or remove it.
Which issue(s) this PR fixes:
Helps fix Loki failing to start due to a corrupt file on the write path as noticed in #3219