Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a chunk filterer field to the config #3979

Merged

Conversation

MichelHollands
Copy link
Contributor

Setting a ChunkFilterer on the ingester currently has to be done after the ingester is created using the SetChunkFilterer() function. This means another target had to be added that depends on the ingester target just to set this.

This PR adds a field to the config so this can be set before the ingester target runs. No flag is added to set the new field.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands marked this pull request as draft July 12, 2021 08:07
@MichelHollands MichelHollands marked this pull request as ready for review July 12, 2021 08:57
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 78b073e into grafana:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants