Headblock interop #3995
Merged
Headblock interop #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sandeepsukhani
approved these changes
Jul 19, 2021
| @@ -74,7 +88,7 @@ type MemChunk struct { | |||
| cutBlockSize int | |||
|
|
|||
| // Current in-mem block being appended to. | |||
| head *headBlock | |||
| head HeadBlock | |||
|
|
|||
| // the chunk format default to v2 | |||
There was a problem hiding this comment.
While we are at it, If I am not wrong, we default to v3 now, and I think we should update this comment too?
There was a problem hiding this comment.
I think its not yet active since NewMemChunk still creates an ordered head.
There was a problem hiding this comment.
I found the DefaultChunkFormat being set to v3. Am I looking at the wrong place?
There was a problem hiding this comment.
This is covered in the followup PR #4001 :)
cyriltovena
reviewed
Jul 19, 2021
| } | ||
|
|
||
| func (hb *unorderedHeadBlock) Reset() { | ||
| x := newUnorderedHeadBlock() |
There was a problem hiding this comment.
Might be interesting instead to use https://github.com/golang-collections/go-datastructures/blob/59788d5eb259/rangetree/entries.go#L33 which will attemps to reuse entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next one working towards enabling out of order writes in Loki. Notably, it
HeadBlockinterface type and ensures both ordered & unordered variants implement it.ref #1544