Restrict path segments in TenantIDs (CVE-2021-36156 CVE-2021-36157) #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20210721_invalidate-path-segements-in-orgid
branch
from
1388334
to
c16be9c
Compare
Updates cortex dependency to prevent paths derived from TenantIDs to become vulnerable to path traversal attacks. CVE-2021-36156 CVE-2021-36157 Signed-off-by: Christian Simon <simon@swine.de>
simonswine
force-pushed
the
20210721_invalidate-path-segements-in-orgid
branch
from
c16be9c
to
39db6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates cortex dependency to prevent paths derived from TenantIDs to become vulnerable to path traversal attacks. CVE-2021-36156 CVE-2021-36157
Edit added more details.
An attacker, with suitable access, could trick Loki into sending the contents of files it has access to.
The vulnerability is that the header value
X-Scope-OrgIDis used to construct file paths for rules files, and if crafted to say something like../../sensitive/path/in/deploymentthen Loki will attempt to parse a rules file at that location and include some of the contents in the error message.Other Loki API requests can also be sent a malicious OrgID header, e.g. tricking the ingester into writing metrics to a different location, but the effect is nuisance rather than disclosure.
Mitigations:
If you have a proxy in front of Loki that supplies the OrgID header, so it cannot be crafted by an attacker, then you are not vulnerable. We always recommend such a proxy
If you run Loki with limited access to sensitive files, e.g. in a container or chroot, and as a user with limited access, then this will constrain the vulnerability to that access.